From e76373cff77f3f8d59641bb59590b918e441ed39 Mon Sep 17 00:00:00 2001 From: Jordan Labrosse Date: Fri, 12 Sep 2025 08:30:46 +0200 Subject: [PATCH 1/2] ci: add conventional commits check workflow --- .../workflows/conventional-commits-check.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/workflows/conventional-commits-check.yaml diff --git a/.github/workflows/conventional-commits-check.yaml b/.github/workflows/conventional-commits-check.yaml new file mode 100644 index 0000000..40a4dc8 --- /dev/null +++ b/.github/workflows/conventional-commits-check.yaml @@ -0,0 +1,49 @@ +name: Conventional Commits Check + +on: + pull_request: + types: [opened, synchronize, reopened, edited] + +jobs: + check-conventional-commits: + name: Conventional Commits + runs-on: ubuntu-latest + permissions: + pull-requests: read + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 0 + + - name: Check Commit Conventions + uses: webiny/action-conventional-commits@v1.3.0 + + - name: Check Semantic Pull Request title + uses: amannn/action-semantic-pull-request@v6 + id: lint_pr_title + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - uses: marocchino/sticky-pull-request-comment@v2 + # When the previous steps fail, the workflow would stop. By adding this + # condition you can continue the execution with the populated error message. + if: always() && (steps.lint_pr_title.outputs.error_message != null) + with: + header: pr-title-lint-error + message: | + Hey there and thank you for opening this pull request! 👋🏼 + + We require pull request titles to follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/) and it looks like your proposed title needs to be adjusted. + + Details: + + ``` + ${{ steps.lint_pr_title.outputs.error_message }} + ``` + + # Delete a previous comment when the issue has been resolved + - if: ${{ steps.lint_pr_title.outputs.error_message == null }} + uses: marocchino/sticky-pull-request-comment@v2 + with: + header: pr-title-lint-error + delete: true From 756a484c0ff5980dd571bd95eaeb1f9c721b1b44 Mon Sep 17 00:00:00 2001 From: Jordan Labrosse Date: Tue, 16 Sep 2025 09:47:26 +0200 Subject: [PATCH 2/2] refactor: apply suggestions --- .../workflows/conventional-commits-check.yaml | 38 +++---------------- 1 file changed, 5 insertions(+), 33 deletions(-) diff --git a/.github/workflows/conventional-commits-check.yaml b/.github/workflows/conventional-commits-check.yaml index 40a4dc8..88c8501 100644 --- a/.github/workflows/conventional-commits-check.yaml +++ b/.github/workflows/conventional-commits-check.yaml @@ -1,8 +1,11 @@ name: Conventional Commits Check on: - pull_request: - types: [opened, synchronize, reopened, edited] + pull_request_target: + types: + - opened + - edited + - reopened jobs: check-conventional-commits: @@ -11,39 +14,8 @@ jobs: permissions: pull-requests: read steps: - - uses: actions/checkout@v5 - with: - fetch-depth: 0 - - - name: Check Commit Conventions - uses: webiny/action-conventional-commits@v1.3.0 - - name: Check Semantic Pull Request title uses: amannn/action-semantic-pull-request@v6 id: lint_pr_title env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - - uses: marocchino/sticky-pull-request-comment@v2 - # When the previous steps fail, the workflow would stop. By adding this - # condition you can continue the execution with the populated error message. - if: always() && (steps.lint_pr_title.outputs.error_message != null) - with: - header: pr-title-lint-error - message: | - Hey there and thank you for opening this pull request! 👋🏼 - - We require pull request titles to follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/) and it looks like your proposed title needs to be adjusted. - - Details: - - ``` - ${{ steps.lint_pr_title.outputs.error_message }} - ``` - - # Delete a previous comment when the issue has been resolved - - if: ${{ steps.lint_pr_title.outputs.error_message == null }} - uses: marocchino/sticky-pull-request-comment@v2 - with: - header: pr-title-lint-error - delete: true