From 9fc86d1ff3c3a080764aa735b56b7e282b8066ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julian=20T=C3=B6lle?= <julian.toelle97@gmail.com>
Date: Fri, 30 Aug 2024 19:14:53 +0200
Subject: [PATCH] refactor: load existing release pr earlier

We need information from the release pr for the following steps, as the
user can override various behaviours by commenting/labeling the release
pr.
---
 releaserpleaser.go | 45 +++++++++++++++++++++------------------------
 1 file changed, 21 insertions(+), 24 deletions(-)

diff --git a/releaserpleaser.go b/releaserpleaser.go
index 5dfcf12..a901377 100644
--- a/releaserpleaser.go
+++ b/releaserpleaser.go
@@ -143,6 +143,27 @@ func (rp *ReleaserPleaser) createPendingRelease(ctx context.Context, pr *Release
 func (rp *ReleaserPleaser) runReconcileReleasePR(ctx context.Context) error {
 	logger := rp.logger.With("method", "runReconcileReleasePR")
 
+	rpBranch := fmt.Sprintf(PullRequestBranchFormat, rp.targetBranch)
+	rpBranchRef := plumbing.NewBranchReferenceName(rpBranch)
+
+	pr, err := rp.forge.PullRequestForBranch(ctx, rpBranch)
+	if err != nil {
+		return err
+	}
+
+	var releaseOverrides ReleaseOverrides
+
+	if pr != nil {
+		logger = logger.With("pr.id", pr.ID, "pr.title", pr.Title)
+		logger.InfoContext(ctx, "found existing release pull request")
+
+		releaseOverrides, err = pr.GetOverrides()
+		if err != nil {
+			return err
+		}
+
+	}
+
 	releases, err := rp.forge.LatestTags(ctx)
 	if err != nil {
 		return err
@@ -172,22 +193,6 @@ func (rp *ReleaserPleaser) runReconcileReleasePR(ctx context.Context) error {
 
 	logger.InfoContext(ctx, "Analyzed commits", "length", len(analyzedCommits))
 
-	rpBranch := fmt.Sprintf(PullRequestBranchFormat, rp.targetBranch)
-	rpBranchRef := plumbing.NewBranchReferenceName(rpBranch)
-	// Check Forge for open PR
-	// Get any modifications from open PR
-	// Clone Repo
-	// Run Updaters + Changelog
-	// Upsert PR
-	pr, err := rp.forge.PullRequestForBranch(ctx, rpBranch)
-	if err != nil {
-		return err
-	}
-
-	if pr != nil {
-		logger.InfoContext(ctx, "found existing release pull request", "pr.id", pr.ID, "pr.title", pr.Title)
-	}
-
 	if len(analyzedCommits) == 0 {
 		if pr != nil {
 			logger.InfoContext(ctx, "closing existing pull requests, no commits available", "pr.id", pr.ID, "pr.title", pr.Title)
@@ -202,14 +207,6 @@ func (rp *ReleaserPleaser) runReconcileReleasePR(ctx context.Context) error {
 		return nil
 	}
 
-	var releaseOverrides ReleaseOverrides
-	if pr != nil {
-		releaseOverrides, err = pr.GetOverrides()
-		if err != nil {
-			return err
-		}
-	}
-
 	versionBump := VersionBumpFromCommits(analyzedCommits)
 	// TODO: Set version in release pr
 	nextVersion, err := rp.nextVersion(releases, versionBump, releaseOverrides.NextVersionType)