mirror of
https://github.com/apricote/releaser-pleaser.git
synced 2026-01-13 13:21:00 +00:00
feat: run one job concurrently to reduce chance of conflicts (#198)
Each run of releaser-pleaser acts on the same global state in the forge. Therefore, parallel runs are unnecessary. This commit also communicates to the GitHub and GitLab CI pipelines that the releaser-pleaser jobs can be cancelled as early as possible. - On GitHub Actions this can be guaranteed through the workflow settings. These settings are copied into each repository that uses releaser-pleaser, so users need to update this manually. I will add a note to the release notes for this. - On GitLab CI/CD this requires the user to configure a project level setting to "auto-cancel redundant pipelines". We will not recommend user to set this, as it is quite invasive and can break their regular CI pipelines.
This commit is contained in:
parent
d24ae7de98
commit
2d3a960939
3 changed files with 21 additions and 0 deletions
7
.github/workflows/releaser-pleaser.yaml
vendored
7
.github/workflows/releaser-pleaser.yaml
vendored
|
|
@ -10,6 +10,13 @@ on:
|
||||||
- labeled
|
- labeled
|
||||||
- unlabeled
|
- unlabeled
|
||||||
|
|
||||||
|
# Only one job needs to run at a time, if a new job is started there is probably new data to include in the response, so
|
||||||
|
# it does not make sense to finish the previous job. This also helps with "data-race conflicts", where a human changes
|
||||||
|
# the PR description but releaser-pleaser was already running and overwrites the humans changes.
|
||||||
|
concurrency:
|
||||||
|
group: releaser-pleaser
|
||||||
|
cancel-in-progress: true
|
||||||
|
|
||||||
permissions: {}
|
permissions: {}
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
|
|
|
||||||
|
|
@ -44,6 +44,10 @@ on:
|
||||||
- labeled
|
- labeled
|
||||||
- unlabeled
|
- unlabeled
|
||||||
|
|
||||||
|
concurrency:
|
||||||
|
group: releaser-pleaser
|
||||||
|
cancel-in-progress: true
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
releaser-pleaser:
|
releaser-pleaser:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|
|
||||||
|
|
@ -26,9 +26,19 @@ spec:
|
||||||
releaser-pleaser:
|
releaser-pleaser:
|
||||||
stage: $[[ inputs.stage ]]
|
stage: $[[ inputs.stage ]]
|
||||||
needs: $[[ inputs.needs ]]
|
needs: $[[ inputs.needs ]]
|
||||||
|
|
||||||
rules:
|
rules:
|
||||||
# There is no way to run a pipeline when the MR description is updated :(
|
# There is no way to run a pipeline when the MR description is updated :(
|
||||||
- if: $CI_COMMIT_BRANCH == "$[[ inputs.branch ]]"
|
- if: $CI_COMMIT_BRANCH == "$[[ inputs.branch ]]"
|
||||||
|
|
||||||
|
# If a newer releaser-pleaser job runs, this one may be cancelled without problem, releaser-pleaser is idempotent.
|
||||||
|
# This only works if the user enables "auto-cancel redundant pipelines", which we do tell them to, because this is
|
||||||
|
# intrusive and up to the user.
|
||||||
|
interruptible: true
|
||||||
|
|
||||||
|
# No need to have multiple releaser-pleaser jobs running at the same time. They all act on the same global state.
|
||||||
|
resource_group: releaser-pleaser
|
||||||
|
|
||||||
image:
|
image:
|
||||||
name: ghcr.io/apricote/releaser-pleaser:v0.5.1 # x-releaser-pleaser-version
|
name: ghcr.io/apricote/releaser-pleaser:v0.5.1 # x-releaser-pleaser-version
|
||||||
entrypoint: [ "" ]
|
entrypoint: [ "" ]
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue