From 9b7a01ab1cd9178b3ea9cb443003313ace5e7ec9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20T=C3=B6lle?= Date: Thu, 16 Jun 2022 23:53:15 +0200 Subject: [PATCH] fix(ci): respect peer deps again The problem causing dependency has been removed and we can once again validate the peer dependencies in CI and during docker build. --- .github/workflows/ci.yaml | 4 ++-- Dockerfile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 0cafa14..128a42f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -22,7 +22,7 @@ jobs: with: node-version: 16 - - run: npm ci --legacy-peer-deps + - run: npm ci - run: npm run build - run: npm run lint:api - run: npm run test:cov @@ -51,7 +51,7 @@ jobs: with: node-version: 16 - - run: npm ci --legacy-peer-deps + - run: npm ci - run: npm ci working-directory: frontend diff --git a/Dockerfile b/Dockerfile index 812ec36..72547c2 100644 --- a/Dockerfile +++ b/Dockerfile @@ -22,7 +22,7 @@ COPY frontend/*.json /app/frontend/ FROM common as build-api LABEL stage="build-api" -RUN npm ci --legacy-peer-deps +RUN npm ci COPY src/ /app/src/ RUN NODE_ENV=production npm run build @@ -52,7 +52,7 @@ RUN NODE_ENV=production npm run build FROM common as app LABEL stage="app" -RUN npm ci --omit=dev --legacy-peer-deps +RUN npm ci --omit=dev COPY --from=build-api /app/dist/ /app/dist/ COPY --from=build-frontend /app/frontend/build /app/static/